Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [DH]: Display record's update status correctly #670

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix [DH]: Display record's update status correctly #670

merged 1 commit into from
Nov 3, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Nov 2, 2023

Currently, the update status coming from cl_status always displays the (translated) fallback value of under_development, because the mapper uses the cl_status object instead of its key.

under_dev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023 •
edited
Loading

Affected libs: api-metadata-converter, feature-editor, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, ui-search,
Affected apps: metadata-converter, metadata-editor, datafeeder, demo, datahub, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 83.126% (+0.03%) from 83.092% when pulling 1b7dade on fix-status into 2901ae6 on main.

@tkohr tkohr added the bug Something isn't working label Nov 2, 2023
jahow
jahow approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!!

@tkohr tkohr merged commit 95ebc52 into main Nov 3, 2023
5 checks passed
@tkohr tkohr deleted the fix-status branch November 3, 2023 11:11
@jahow
Copy link
Collaborator

jahow commented Nov 7, 2023

backported on 2.0.x by 5641203

@tkohr tkohr mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
backport 2.0.x bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkohr @coveralls @jahow